Skip to content

helm: add per shard backup cron jobs#4356

Merged
dkhenry merged 1 commit intovitessio:masterfrom
derekperkins:cronjob-backups
Nov 16, 2018
Merged

helm: add per shard backup cron jobs#4356
dkhenry merged 1 commit intovitessio:masterfrom
derekperkins:cronjob-backups

Conversation

@derekperkins
Copy link
Copy Markdown
Member

@derekperkins derekperkins commented Nov 9, 2018

This creates a native kubernetes cron job that executes according to a customer provided schedule to run backups. The schedule can be defined globally or can be overridden on a per-shard basis.

After #4333 is merged, we'll need to add the extra flags to this call as well to support encryption and any other user provided flags. Done

@derekperkins
Copy link
Copy Markdown
Member Author

@trevex Can you take a look to make sure that I used your extra flags correctly?

Signed-off-by: Derek Perkins <derek@derekperkins.com>
Copy link
Copy Markdown
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkhenry dkhenry merged commit 088b121 into vitessio:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants